tickets
17 rows where "created" is on date 2008-09-02 and has_patch = 1 sorted by needs_docs
This data as json, CSV (advanced)
Suggested facets: changetime, stage, component, owner, reporter, needs_better_patch, ui_ux
id | created | changetime | last_pulled_from_trac | stage | status | component | type | severity | version | resolution | summary | description | owner | reporter | keywords | easy | has_patch | needs_better_patch | needs_tests | needs_docs ▼ | ui_ux |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
8787 | 2008-09-02 00:58:46 | 2011-09-28 16:12:17 | 2022-03-06 03:43:10.149129 | Accepted | closed | contrib.admin | dev | fixed | Tests are currently failing on django trunk | It's the admin_widget tests. | nobody | Alex | 1.0-blocker | 0 | 1 | 0 | 0 | 0 | 0 | ||
8788 | 2008-09-02 03:55:18 | 2011-09-28 16:12:17 | 2022-03-06 03:43:10.312116 | Ready for checkin | closed | Documentation | dev | fixed | correction for some typos in #8805 | {{{ Index: django/forms/models.py =================================================================== --- django/forms/models.py (revision 8831) +++ django/forms/models.py (working copy) @@ -244,7 +244,7 @@ if self.instance.pk is not None: qs = qs.exclude(pk=self.instance.pk) - # This cute trick with extra/values is the most efficiant way to + # This cute trick with extra/values is the most efficient way to # tell if a particular query returns any results. if qs.extra(select={'a': 1}).values('a').order_by(): model_name = capfirst(self.instance._meta.verbose_name) Index: docs/topics/forms/modelforms.txt =================================================================== --- docs/topics/forms/modelforms.txt (revision 8831) +++ docs/topics/forms/modelforms.txt (working copy) @@ -337,10 +337,10 @@ Overriding the clean() method ----------------------------- -You can overide the ``clean()`` method on a model form to provide additional +You can override the ``clean()`` method on a model form to provide additional validation in the same way you can on a normal form. However, by default the ``clean()`` method validates the uniqueness of fields that are marked as unique -on the model, and those marked as unque_together, if you would like to overide +on the model, and those marked as unique_together, if you would like to override the ``clean()`` method and maintain the default validation you must call the parent class's ``clean()`` method. }}} | nobody | Matthew Flanagan <mattimustang@gmail.com> | 0 | 1 | 0 | 0 | 0 | 0 | |||
8791 | 2008-09-02 08:48:24 | 2008-09-02 10:19:07 | 2022-03-06 03:43:10.786973 | Unreviewed | closed | Translations | dev | fixed | Turkish translation updates | Here's another (and hopefully last) update for Turkish tanslations. Many additions and corrections. | nobody | amiroff | turkish tr | 0 | 1 | 0 | 0 | 0 | 0 | ||
8796 | 2008-09-02 14:22:12 | 2011-09-28 16:12:17 | 2022-03-06 03:43:11.579563 | Unreviewed | closed | Translations | dev | fixed | Last update of Brazilian Portuguese (pt_BR) localization for Django 1.0 final | Some translations improved and added new translations. Please, if possible, apply this patch latest as possible, because is probably that we are going to have new changes later today. Thanks! :-) | nobody | Guilherme M. Gondim <semente@taurinus.org> | pt_BR | 0 | 1 | 0 | 0 | 0 | 0 | ||
8798 | 2008-09-02 15:44:42 | 2012-10-15 21:16:47 | 2022-03-06 03:43:11.884053 | Accepted | closed | contrib.localflavor | New feature | Normal | dev | invalid | Add DEPhoneNumberField to German localflavor module | This ticket tries to add a {{{DEPhoneNumberField}}} class to the German localflavor module. There are several valid standards in Germany: DIN 5008, E.123 and an informal format which have national and international notations. More information: http://de.wikipedia.org/wiki/Rufnummer#Schreibweisen | jezdez | jezdez | locale, localflavor, german, phone, number, localflavorsplit | 0 | 1 | 0 | 0 | 0 | 1 |
8800 | 2008-09-02 15:59:36 | 2008-12-08 02:35:31 | 2022-03-06 03:43:12.198834 | Unreviewed | closed | *.djangoproject.com | dev | fixed | New docs search producing invalid HTML | Very minor, but I noticed that my patch from #8723 that was committed in [8844] contains errors which causes the new docs site to produce invalid HTML. The script tag in `search_form.html` has an unescaped ampersand (this was actually copied and pasted from Google's example code). Also, it looks like the `lang` variable is never populated. The attached (untested) patch should hopefully fix both of these. | jacob | frasern | 0 | 1 | 0 | 0 | 0 | 0 | |||
8802 | 2008-09-02 17:16:22 | 2011-09-28 16:12:17 | 2022-03-06 03:43:12.490927 | Accepted | closed | Documentation | dev | fixed | Document database-dependent behavior of BooleanField. | As noted in http://code.djangoproject.com/ticket/7190, BooleanField can be either an int or a bool depending on the database used. This bit of non-deterministic behavior should be documented very clearly. -Dave | jacob | stengleind | 0 | 1 | 0 | 0 | 0 | 0 | |||
8803 | 2008-09-02 17:36:53 | 2008-10-05 05:18:25 | 2022-03-06 03:43:12.638756 | Unreviewed | closed | contrib.comments | dev | fixed | Possibility to use username if full name is missing in the comments framework | The ticket summary mentions it all. After a discussion with Jacob on IRC, it was decided to have this though having the full name is always recommended. | nobody | thejaswi_puthraya | fullname, username, comments | 0 | 1 | 0 | 0 | 0 | 0 | ||
8804 | 2008-09-02 17:38:57 | 2011-09-28 16:12:17 | 2022-03-06 03:43:12.787520 | Accepted | closed | Documentation | dev | fixed | Documentation example gives wrong result | {{{ (r'^sitemap-(?P<section>.+).xml$', 'django.contrib.sitemaps.views.sitemap', {'sitemaps': sitemaps}) }}} This won't work. and results in sitemap-mysectionnamexxml instead of sitemap-mysectionname.xml This will work: {{{ (r'^sitemap-(?P<section>.+)\.xml$', 'django.contrib.sitemaps.views.sitemap', {'sitemaps': sitemaps}) }}} | nobody | toke | 0 | 1 | 0 | 0 | 0 | 0 | |||
8806 | 2008-09-02 18:38:01 | 2009-02-25 19:51:44 | 2022-03-06 03:43:13.075868 | Unreviewed | closed | contrib.admin | dev | duplicate | ModelAdmin should allow not default manager | My use case is this: I have a model with two Managers - one named objects (the default), and another one. I want the admin to use the non-default one (in my case I can't even give it the default one since it doesn't return instances of the model, but of another model it inherits from). So my solution (It doesn't even merit a patch - its just 3 lines changed in django/contrib/admin/options.py): # my code from django.contrib import admin class MyAdmin(admin.ModelAdmin): model = MyModel manager = MyModel.othermanager # unified diff against django/contrib/admin/options.py svn 8851 --- a/django/contrib/admin/options.py +++ b/django/contrib/admin/options.py @@ -166,6 +166,8 @@ class ModelAdmin(BaseModelAdmin): ordering = None inlines = [] + manager = None + # Custom templates (designed to be over-ridden in subclasses) change_form_template = None change_list_template = None @@ -239,7 +241,10 @@ class ModelAdmin(BaseModelAdmin): Returns a QuerySet of all model instances that can be edited by the admin site. This is used by changelist_view. """ - qs = self.model._default_manager.get_query_set() + if self.manager is None: + qs = self.model._default_manager.get_query_set() + else: + qs = self.manager.get_query_set() # TODO: this should be handled by some parameter to the ChangeList. ordering = self.ordering or () # otherwise we might try to *None, which is bad ;) if ordering: | nobody | alon | ModelAdmin,Manager | 0 | 1 | 0 | 0 | 0 | 0 | ||
8807 | 2008-09-02 18:54:10 | 2011-09-28 16:12:17 | 2022-03-06 03:43:13.233283 | Unreviewed | closed | Forms | dev | duplicate | django.forms.utils.ValidationError should be a subclass of django.core.exceptions.ValidationError | Seems that this should be true as they are kinda the same thing, but in a different context (i.e. sometimes hard to figure out which ValidationError is thrown in a try except) | nobody | magneto | 0 | 1 | 0 | 0 | 0 | 0 | |||
8808 | 2008-09-02 19:04:04 | 2011-06-01 15:37:55 | 2022-03-06 03:43:13.384797 | Design decision needed | closed | contrib.formtools | New feature | Normal | dev | fixed | Form Wizard keeps state on subsequent requests and provides no way to cut short inside parse_params | Since this issue is subtle I'll describe my concrete usecase first and than describe the issue and possible solutions to this. '''Usecase:''' I have a form that contains a ChoiceField which depends on the currently logged in user and some request parameters. Since I need a special behaviour I subclassed the FormWizard and did overwrite the methods {{{parse_params}}}, {{{done}}}, {{{process_step}}}, {{{get_form}}} and {{{get_template}}}. Inside {{{parse_params}}} I set some attributes of self. For some reason I assumed that returning anything but None would cause the Wizard to abort. However the return value is ignored and the wizard code continues by calling {{{get_form}}} and {{{process_step}}}. Since {{{get_form}}} is the only way of putting the stuff which was set earlier in {{{parse_params}}} I have a hook that calls some helper methods on the form to set up the options of the ChoiceField depending on the stuff set by {{{parse_params}}} earlier. Since the only way of injecting custom data there is {{{self}}} one has no chance of telling wether the value comes from the current request or something earlier which might just have failed. Thus no AttributeError is raised as the attribute is set. The data just does not come from the current request. Even worse: In my case - since I was assuming that returning from {{{parse_params}}} with an {{{HttpResponse}}} would stop the wizard and return the HttpResponse immediately - caused invalid requests to be rendered with the state from a previous requests. A horrid leak of sensible data, as the wizard is part of a checkout process and the {{{ChoiceField}}} is used to pick an address. I'm just glad our QA noticed that glitch before putting this stuff live. It would not be hard to exploit and I don't like the idea of leaking sensible data. '''Solutions:''' 1. By overwriting the {{{__call__}}} method one can inject any attribute into self and return any HttpResponse object if something is wrong. I consider this rather ugly as the FormWizard explicitly state… | nobody | Michael P. Jung | FormWizard, state, parse_params, shortcut, HttpResponse | 0 | 1 | 0 | 0 | 0 | 0 |
8809 | 2008-09-02 19:58:37 | 2015-01-30 17:09:54 | 2022-03-06 03:43:13.545045 | Accepted | closed | Core (URLs) | New feature | Normal | dev | wontfix | Better error message when can't import url callback | in django.core.urlresolvers _get_callback it would be helpful to display not just the module name that couldn't be imported, but the entire urls.py line that was the problem. Without more information it's incredibly hard to track down WHICH urls.py file has the problem and which line in that file is problematic. | nobody | TP | error message | 0 | 1 | 1 | 0 | 0 | 0 |
8811 | 2008-09-02 20:41:02 | 2011-09-28 16:12:17 | 2022-03-06 03:43:13.872029 | Unreviewed | closed | Documentation | dev | fixed | urls.py example of tutorial part 2 has Django template-style vars | `"mysite"` should appear instead of `{{ project_name }}` | nobody | ramiro | 0 | 1 | 0 | 0 | 0 | 0 | |||
8812 | 2008-09-02 20:44:39 | 2011-09-28 16:12:17 | 2022-03-06 03:43:14.019887 | Accepted | closed | contrib.admin | dev | fixed | Delete link should be right-aligned when admin interface is RTL | The class of the P tag that contains the 'deletelink' should be float-right rather than float-left for it to be displayed correctly. Currently it is: {{{<p class="float-left"><a href="delete/" class="deletelink">delete</a></p>}}} and should be {{{<p class="float-right"><a href="delete/" class="deletelink">delete</a></p>}}} | nobody | okhayat | 0 | 1 | 0 | 0 | 0 | 0 | |||
8815 | 2008-09-02 21:18:55 | 2011-09-28 16:12:17 | 2022-03-06 03:43:14.520226 | Unreviewed | closed | Translations | dev | fixed | Final Arabic translation update and QA | Final QA and changed after testing the translation. | nobody | okhayat | arabic | 0 | 1 | 0 | 0 | 0 | 0 | ||
8817 | 2008-09-02 22:48:31 | 2011-09-28 16:12:21 | 2022-03-06 03:43:14.814460 | Ready for checkin | closed | File uploads/storage | dev | fixed | Accessing ImageField's dimensions doesn't close file | If you access an ImageField's width or height property, the corresponding image file doesn't seem to be closed after retrieving its dimensions: After retrieving a lot of image dimensions (of different images), Django produces strange errors ("cannot open template file ..." etc.) which seem to result from too many files being open by the process. Manually calling the close() method of the ImageFieldFile object (after accessing the width and height properties) resolves these errors, so it seems it isn't not called automatically... | mitsuhiko | tripediac | 0 | 1 | 0 | 0 | 0 | 0 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE tickets ( id int primary key, created datetime, changetime datetime, last_pulled_from_trac datetime, stage text, status text, component text, type text, severity text, version text, resolution text, summary text, description text, owner text, reporter text, keywords text, easy boolean, has_patch boolean, needs_better_patch boolean, needs_tests boolean, needs_docs boolean, ui_ux boolean );