tickets: 8660
This data as json
id | created | changetime | last_pulled_from_trac | stage | status | component | type | severity | version | resolution | summary | description | owner | reporter | keywords | easy | has_patch | needs_better_patch | needs_tests | needs_docs | ui_ux |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
8660 | 2008-08-28 22:47:55 | 2009-02-25 19:51:44 | 2022-03-06 03:42:50.422138 | Accepted | closed | contrib.auth | dev | fixed | Calling User.get_profile() should pre-populate the user foreign key on the profile object | When you use the User.get_profile() method to fetch a profile object, it doesn't pre-populate profile's user attribute. This results in unnecessary DB queries when you go from User -> `UserProfile` and then later go from `UserProfile` -> `User`. This is actually a fairly common use case because people tend to attach methods that "extend" the user object in UserProfile, since they can't directly extend User. For example, if you create a `full_name()` method on `UserProfile` that returns {{{'%s %s' % (self.user.first_name, self.user.last_name)}}}, then in your templates, you do {{{ {{ User.get_profile.full_name }} }}}, you end up doing two DB queries when only one in necessary. The solution seems simple enough since the profile's User object must be called `user`. In django/contrib/auth/models.py a one liner after fetching the profile should do the trick: {{{ self._profile_cache = model._default_manager.get(user__id__exact=self.id) + self._profile_cache.user = self }}} | nobody | mmalone | cache profile user auth | 0 | 0 | 0 | 0 | 0 | 0 |