tickets: 7838
This data as json
id | created | changetime | last_pulled_from_trac | stage | status | component | type | severity | version | resolution | summary | description | owner | reporter | keywords | easy | has_patch | needs_better_patch | needs_tests | needs_docs | ui_ux |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
7838 | 2008-07-19 15:25:58 | 2008-07-19 15:51:48 | 2022-03-06 03:40:41.461382 | Unreviewed | closed | Documentation | dev | fixed | Type inconsistency in part 2 of the tutorial | In the "''Customize the admin form''" section, we have the following code snippet: {{{ #!python class PollAdmin(admin.ModelAdmin): fieldsets = [ (None, {'fields': ['question']}), ('Date information', {'fields': ['pub_date'], 'classes': 'pub_date'}), ] }}} But that should be: {{{ #!python class PollAdmin(admin.ModelAdmin): fieldsets = [ (None, {'fields': ['question']}), ('Date information', {'fields': ['pub_date'], 'classes': ['collapse']}), ] }}} There are two issues here with the {{{classes}}} attribute: * the argument should be {{{collapse}}}, not {{{pub_date}}} * and should be an iterable sequence, not a string as in the admin is then rendered as "{{{c o l l a p s e}}}" (iterating over the chars) Now it's not clear what should be the right behaviour: accept both iterable sequences and strings (by "special casing" them, a {{{if type(sequence) == str: sequence = [sequence]}}} should do the work), or raising some error if the wrong type is passed. The same error is in the second example of the "''Adding related objects''" section. | nobody | kratorius | doc documentation newforms-admin nfa | 0 | 1 | 0 | 0 | 0 | 0 |