tickets: 4045
This data as json
| id | created | changetime | last_pulled_from_trac | stage | status | component | type | severity | version | resolution | summary | description | owner | reporter | keywords | easy | has_patch | needs_better_patch | needs_tests | needs_docs | ui_ux |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 4045 | 2007-04-14 19:05:31 | 2013-04-06 11:51:55 | 2022-03-06 03:30:18.558246 | Accepted | closed | contrib.admin | Bug | Normal | dev | fixed | some admin Javascript fixes and cleanups | I recognised that the calendar behaves a bit different in Konqueror than in Firefox: When clicking inside the calendar but not on a element with functionality (e.g. month name) the calendar is closed in Konqueror but not in Firefox. This lead me to the first part of my patch: - Attach "onclick" events to "document" instead of "window". Konqueror does not deliver the event to "window" even when the propagation was stopped. Internet Explorer (tested with IE6 SP2 at a friend computer) does not deliver the event at all to "window". AFAIK "window" in not part of DOM so "document" should be more portable. I have tested the new code with Firefox, Explorer, Safari, Konqueror and Opera. The other parts are only minor cleanups: - Event handlers set in openClock/openCalendar are removed in dismissClock/dismissCalendar ("window.onclick = null;" does not work since handlers are installed with addEvent). - Calendar inserts dates with leading zeroes. - Remove duplicates of functions "quickElement" and "addEvent". - Move "removeChildren" and "cancelEventPropagation" to "core.js" as they might be handy also at other places. If you want a patch with only some parts included let me know. | andrewjesaitis | arvin | admin calendar | 0 | 1 | 1 | 0 | 0 | 0 |